#18732: Add tableau query functions glp_eval_tab_row, glp_eval_tab_col to GLPK
backend
-------------------------------------+-------------------------------------
       Reporter:  mkoeppe            |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.8
      Component:  numerical          |   Resolution:
       Keywords:  LP, glpk           |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/yzh/add_tableau_query_functions_glp_eval_tab_row__glp_eval_tab_col_to_glpk_backend|
  380dfb55b3966cd836fa1fbdc8325a9b3df8920e
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * commit:   => 380dfb55b3966cd836fa1fbdc8325a9b3df8920e


Comment:

 Hello !

 Could you allocate memory *after* raising an exception? Otherwise, those
 exceptions trigger memory leaks.

 `sig_on` and `sig_off` should always appear in pairs, but perhaps you
 should use `sig_check` in this special case?
 http://www.sagemath.org/documentation/html/en/developer/coding_in_cython.html
 #interrupt-and-signal-handling

 Can you check that the pointers you allocate are not 'null'?

 Nathann
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=380dfb55b3966cd836fa1fbdc8325a9b3df8920e
 380dfb5]||{{{Add tableau query functions eval_tab_row, eval_tab_col to
 GLPK backend.}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18732#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to