#18540: Make DirichletGroup a new-style parent
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.8
Component: number theory | Resolution:
Keywords: Dirichlet group | Merged in:
Authors: Peter Bruin | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/18540-DirichletGroup_Parent|
b92b5b00d366e547a862a857783470a9e2ac71c6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
* reviewer: => Jeroen Demeyer
* component: modular forms => number theory
* type: task => enhancement
Comment:
1. In the docstring of `DirichletGroup_class`, could you replace
{{{
Group of Dirichlet characters modulo `N` over a ring `R`.
}}}
by
{{{
Group of Dirichlet characters modulo `N` with values in a ring `R`.
}}}
(or something similar)
2. In the check
{{{
if isinstance(x, (int, rings.Integer)) and x == 1:
}}}
I think it is better to remove `isinstance(x, (int, rings.Integer))` and
allow any kind of `1` (but then you will probably need to add a
`try`/`except` in case that `x == 1` fails).
--
Ticket URL: <http://trac.sagemath.org/ticket/18540#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
