#18761: method submatrix of matrix_mod2_dense needs default arguments
-------------------------------------+-------------------------------------
Reporter: cnassau | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: linear algebra | Resolution:
Keywords: dense matrix, sub | Merged in:
matrix | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3549edfeec4bdcc3976963b021f19807afd9eaa6
u/cnassau/submatrix_signature | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by cnassau):
I have given the submatrix methods the same signature as in file
"matrix1.pyx". This includes a name change of the arguments, because in
parts of Sage (eg, `ChainComplex._homology_generators_snf`) the method is
called with named arguments.
I also made this change:
{{{
- if self._ncols == 0 or self._nrows == 0:
+ if ncols == 0 or nrows == 0:
}}}
This fixed a segfault in my tests, and also seems to make more sense that
the original: one returns an uninitialized matrix if *it* is empty, not if
*self* is empty.
Caveat: I have no detailed understanding of m4rie, someone knowledgeable
might want to have a look at my changes.
--
Ticket URL: <http://trac.sagemath.org/ticket/18761#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
