#18749: Groebner basis computations with the F4 algorithm
-------------------------------------+-------------------------------------
       Reporter:  tcoladon           |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.8
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:  F4, groebner       |    Reviewers:
  basis, ideal                       |  Work issues:
        Authors:  Titouan Coladon    |       Commit:
Report Upstream:  N/A                |  cf1952a78d21e5778ca358dff120166d184a86c4
         Branch:  u/malb/t18749_f4   |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 1. Is there an "upstream" page? It should be mentioned in `SPKG.txt`.

 2. Is this right?
 {{{
 == License ==

  * GNU GPLv3
 }}}
 It would be much better if it was under GPL version 3 ''or later''. If
 this isn't the case, you should ask upstream if they are willing to
 release under GPL version 3 or later.

 3. Obviously, this shouldn't be there:
 {{{
 Put a bulleted list of dependencies here:
 }}}

 4. In `module_list.py`, this shouldn't be needed
 {{{
 depends = [SAGE_INC + "/libf4.h"]
 }}}
 since you're explicitly refering to `libf4.h` in the `.pyx` file.

 5. For the copyright statement in `groebner_basis_f4.pyx`, please follow
 the format at
 [http://doc.sagemath.org/html/en/developer/coding_basics.html#headings-of-
 sage-library-code-files]

 6. When you're done, remove `# commented out code`, in particular this
 funny thing:
 {{{
 #include <Python.h>
 }}}

 7. Format `INPUT` blocks like
 [http://doc.sagemath.org/html/en/developer/coding_basics.html#the-
 docstring-of-a-function-content]

--
Ticket URL: <http://trac.sagemath.org/ticket/18749#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to