#18739: Wrap PARI functions for converting relative number field elements
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.8
      Component:  interfaces         |   Resolution:
       Keywords:  pari               |    Merged in:
        Authors:  Peter Bruin        |    Reviewers:  Frédéric Chapoton
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/18739                |  d27251de48beac243d5c3b1d8e6f4b607c375303
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by chapoton):

 * commit:  5055d694d750f40db8f931d12abcff0d74233ed5 =>
     d27251de48beac243d5c3b1d8e6f4b607c375303
 * branch:  u/pbruin/18739-pari_rnf_conversion => public/ticket/18739
 * reviewer:   => Frédéric Chapoton


Comment:

 Looks good to me.

 I have used this opportunity to
 - correct one typo in the doc (missing `::`)
 - put all `raise` statements into python3 syntax.

 I you agree with these cosmetic changes, you can set a positive review on
 my behalf.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=566770a42a5e7f6c22c8449e2e0f0b57cdb7808c
 566770a]||{{{Merge branch 'u/pbruin/18739-pari_rnf_conversion' into
 6.8.b5}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=88fbd3d61d0c316aadffaa980c90d0f7eb16eb00
 88fbd3d]||{{{trac #18379 doc typo in pari/gen}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d27251de48beac243d5c3b1d8e6f4b607c375303
 d27251d]||{{{trac #18739 raise into py3 syntax}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/18739#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to