#18626: fix gap_packages (Guava) optional tests
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers:
Authors: Dima Pasechnik | Work issues:
Report Upstream: Fixed upstream, | Commit:
in a later stable release. | a26ecb319bf7b5b9239e3d925407c48b1ace7d86
Branch: u/dimpase/18626 | Stopgaps:
Dependencies: #18689 |
-------------------------------------+-------------------------------------
Comment (by dimpase):
Replying to [comment:20 ncohen]:
> Hello Dima,
>
> In this patch you add a block of code with is indented with 3 spaces
instead of 4, right before a block of code with a 4-spaces indentation. So
you have a 'if' inside of a loop, just because of 1 space. The code seems
to behave as intended.
>
ok, I'll fix this.
> This being said, wouldn't it be better to *not* move this big block of
code, and just add this?
> {{{
> if gap("Length(matCwt)") <= 0:
> continue
> }}}
IMHO, `continue` is even less readable than `goto`...
--
Ticket URL: <http://trac.sagemath.org/ticket/18626#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
