#18734: Construct an interactive_simplex_method.LPDictionary from a
MixedIntegerLinearProgram
-------------------------------------+-------------------------------------
       Reporter:  mkoeppe            |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.8
      Component:  numerical          |   Resolution:
       Keywords:  lp                 |    Merged in:
        Authors:  Aedi Wang          |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/zwang/construct_an_interactive_simplex_method_lpdictionary_from_a_mixedintegerlinearprogram|
  c14b07d296e806f080711366dc1d720cc871abd9
   Dependencies:  #18685, #18688,    |     Stopgaps:
  #18732, #18733                     |
-------------------------------------+-------------------------------------
Changes (by ncohen):

 * status:  needs_review => needs_work


Comment:

 Hello,

 You assume in this code that the backend is GLPK. Also, I have to say that
 I do not like this `get_variables` function much. It returns to the users
 the symbolic variables of the LP, to which he already has access through
 his calls to `new_variable`. We may need this kind of things for our own
 methods, but in this case I think that it would be better to work directly
 with the integer id of the variables than with the symbolic ones.

 That woud lead us to make function like `get_values` accept an integer
 parameter (a variable's id), which is not a bad move. Especially if we
 plan to work with the dual LP later.

 Also, return {{{[k for k in self._variables.keys()]}}} is better written
 as {{{self._variables().keys()}}}

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/18734#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to