#18826: A sage-sanity-check-package using the 'spkg-src' scripts
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.8
enhancement | Resolution:
Priority: major | Merged in:
Component: build | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Nathann Cohen | fa4edd7810fb1d599f08d01c79a8183a0a806eae
Report Upstream: N/A | Stopgaps:
Branch: |
public/18826 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> 1. The `spkg-src` script should only be run within a Sage shell.
I updated the sanity-check script on this respect.
> 1. The `spkg-src` script should be runnable from any directory (do not
assume the current directory is `build/pkgs/PKGNAME`)
I checked that too, using your test.
> 1. The tarball should be created in the `$SAGE_DISTFILES` directory.
Also checked.
> 1. The script should not change any file (not even temporary) outside
`$SAGE_DISTFILES`.
I do not know how to check that. Is it easily done? It does not seem so
important that we should go out of our way to check it.
> 1. The resulting tarball should be either uncompressed with a `.tar`
extension of bzipped with a `.tar.bz2` extension.
We also have many .tar.gz in 'upstream/'. But I do not see a need to
enforce something like that.
> 1. The `spkg-src` script should use `sage-download-file` to download
files (not `curl` or `wget`, which are not installed on all systems).
Why would you make such restrictions? Those spkg-src scripts are run
manually and by developpers, at the moment. They know how to deal with a
'wget not found'.
> 1. All directories in the tarball should have 0755 permission. All
ordinary files should have 0755 or 0644 permission. ''Possibly add:''
every file which has 0755 permission must start with `#!`.
> 1. All symlinks in the tarball must be relative and point to an existing
file.
I do not think that we need any of those two, but I don't see any reason
to oppose you on that. The best for this is probably to try it on several
packages, and figure out if this is a reasonable assumption to make. If
packages don't already satisfy that, I don't see what we could do against
it.
> Such an assumption was needed for old-style spkg files due to the way
that sage-spkg works, but for new-style packages this is really not
needed.
I do not see how to avoid it: if you do, you can add a commit.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18826#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
