#18769: Implement affinization crystal and allow KyotoPathModel to use extended
weight lattice
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: combinatorics | Resolution:
Keywords: crystals | Merged in:
Authors: Travis Scrimshaw | Reviewers: Ben Salisbury
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/crystals/kyoto_path_model_weight-18769|
48b4df96f4f56ae08e87791a2c2bfb2c8a6db1c4
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bsalisbury1):
* reviewer: => Ben Salisbury
Comment:
I found some typos, failed documentation builds, and failed doctests.
These have all been fixed and now tests pass and documentation looks good.
More to the point, the weight function seems to have the desired behavior
and the affinization crystal looks good.
One comment: the weight function in `kyoto_path_model` was displaying the
affine weight in a weird way. For example, one output was `-delta +
Lambda[0]` when one would usually expect `Lambda[0] - delta`. I fixed the
doctests so they pass, but I did not attempt to change the display of the
weight so that it would come out (for example) as `Lambda[0] - delta`. If
this still bothers anyone, then it will have to be fixed.
...Otherwise, it looks good to me. Any other comments?
Best,
Ben
--
Ticket URL: <http://trac.sagemath.org/ticket/18769#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
