#18839: Boost Dominator Tree
-------------------------------------+-------------------------------------
       Reporter:  borassi            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  graph theory       |   Resolution:
       Keywords:  Dominator tree,    |    Merged in:
  Boost                              |    Reviewers:
        Authors:  Michele Borassi    |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  4d1b5ac6214a68ed2d918443bdac80f039dc2841
  u/borassi/boost_dominator_tree     |     Stopgaps:
   Dependencies:  #18811, #18564     |
-------------------------------------+-------------------------------------

Comment (by dcoudert):

 Nicely done.

 May be you could combine methods  `dominator_tree_dictionary` and
 `dominator_tree` using an optional parameter (e.g., `return_dict=False`) ?

 Actually I don't know which is the most useful: the tree or the
 dictionary.

 Also, I suggest
 {{{
 - edges = [[v,dom_tree_dict[v]] for v in dom_tree_dict.keys() if
 dom_tree_dict[v] is not None]
 + edges = [[v,dom_v] for v,dom_v in dom_tree_dict.iteritems() if not dom_v
 is None]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18839#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to