#1321: [with patch, needs work] graphs: an interactive graph editor
---------------------------+------------------------------------------------
Reporter: jason | Owner: rlm
Type: enhancement | Status: new
Priority: major | Milestone: sage-4.1.2
Component: graph theory | Keywords:
Reviewer: Robert Miller | Author: Radoslav Kirov
Merged: |
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):
* cc: boothby (added)
* reviewer: => Robert Miller
* milestone: sage-wishlist => sage-4.1.2
* author: => Radoslav Kirov
Comment:
I've made the patches and files themselves available. This will make
review/discussion easier.
On top of a fresh copy of Sage-4.1.1, I:
1. Applied the patch to the library. There was a rejected hunk, which I
fixed, and posted the modified patch as `trac_1321-graph_editor-
rebased-4.1.1.patch`. (Since the original patch was not an `hg` patch, my
name got put on the patch when I exported it. We'll need to fix this so
that Rado gets proper credit.)
2. Copied the html and js files to
`$SAGE_ROOT/local/notebook/javascript/graph_editor`, after creating this
directory.
3. Rebuilt Sage and tried it out.
REFEREE COMMENTS:
1. This only works from within the notebook, if you run it on a command
line it just spits out some HTML. The variable `EMBEDDED_MODE` is used to
tell whether this is the case or not. We should do something more
intelligent for the command line case.
2. When you update, it always defines the graph `G`, even if that was not
the graph you were actually using. You can get Python to tell you the
variable name used somehow, but at the moment I forget.
3. Also, when you update, it defines the graph as capital `G`, and then
sets the position of lowercase `g`. This gives an error when it is
actually evaluated.
4. Finally, the js file seems particularly averse to whitespace. This
looks like the result of some obfuscation program or something... Can I
suggest we format it a little better?
5. Instead of `graph_editor(G)`, we should probably organize it as
`G.edit()` or `G.graph_editor()` or something like that.
6. I really like this, and I want to see it merged ASAP!!!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/1321#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
