#18864: New method for the eccentricity
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  dcoudert               |       Status:  needs_review
           Type:         |    Milestone:  sage-6.8
  enhancement            |   Resolution:
       Priority:  minor  |    Merged in:
      Component:  graph  |    Reviewers:
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:  David  |  873f62d1113634784413c7995e6f78cc7221d702
  Coudert                |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/18864           |
   Dependencies:         |
-------------------------+-------------------------------------------------

Comment (by borassi):

 Hellooooo!

 Great, now the algorithm should be much faster!

 I think there is still a problem with directed graphs: the Takes-Kosters
 algorithm works only on undirected graphs, so I think you should add a
 `ValueError` if the user asks the Takes-Kosters algorithm on directed
 graphs. I would add at the top of c_eccentricity_bounding

 {{{
 if G.is_directed():
     raise ValueError("The bounds method only works on undirected graphs.")

 }}}
 After you correct this, I will try to perform a more extensive testing,
 and I will provide a positive review!

--
Ticket URL: <http://trac.sagemath.org/ticket/18864#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to