#18904: Automatically test optional non-packages (CPLEX, Gurobi, Maple?, ..)
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  needs_work
           Type:         |    Milestone:  sage-6.8
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:
  doctest framework      |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  9a011eb0a49a3041ae8574e9ce760a8556516417
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/18904           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work


Comment:

 Are we sure that we actually ''want'' to do this? We have no control over
 those external packages. What if somebody has `magma` but with a version
 that is not fully compatible with Sage? With Sage's optional packages,
 that issue does not occur since we have full control over those packages.

 A few comments on the code:
 1. Never use `except:`. Use `except Exception:` or some other specific
 exception class.
 2. Code structure: can we please move all this detect-optional-packages
 code to a separate function?
 3. Performance: how much time does it take to run all those tests? Note
 that #13540 has a system for "lazy" checking of optional dependencies: the
 check for a given package is only done if we are actually running a test
 involving that package.

--
Ticket URL: <http://trac.sagemath.org/ticket/18904#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to