#6378: [with second patch, needs review] make sage -merge more user-friendly
--------------------------+-------------------------------------------------
Reporter: boothby | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.1.2
Component: build | Keywords:
Reviewer: Craig Citro, | Author: Tom Boothby, Craig Citro
Merged: |
--------------------------+-------------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Craig Citro,
* author: boothby => Tom Boothby, Craig Citro
Comment:
I'm generally happy with Tom's changes. In fact, one should note that no
patch of his needs merged -- these changes are already live in sage 4.1
and 4.1.1. Looks like someone's been editing trunk. (`*tsk tsk*`)
My referee report comes in the form of two new patches, one for the bin
repo, and the other for the main repo. The change to the main repo is tiny
-- it's just changing `sage/misc/hg.py` to use the new `subprocess` module
instead of `popen3`, because the deprecation warning is annoying to see in
the output of `sage -merge`. I could easily be convinced to move this to a
new ticket, if people would prefer that.
The patch to the bin repo does the following:
* remove a dirty hack involving `tee` by using python's `subprocess`
module
* add a few comments about the hackish parsing of trac pages
* use `urllib2` to parse urls
* be (unnecessarily?) pedantic about `os.path.join` instead of explicit
use of `/`
* clean up some spacing and indentation issues
* add an option to e-mail when a run of `sage -merge -a` finishes
I ran some tests, but I didn't do any exhaustive testing on `sage.math`,
which should probably be done. (I'm currently on vacation, and without
good internet access.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6378#comment:7>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
