#6568: [with patch, positive review] Migrate Notebook to Jinja
-------------------------+--------------------------------------------------
Reporter: timdumol | Owner: timdumol
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.1.2
Component: notebook | Keywords: notebook, jinja, templating engine
Reviewer: | Author: Tim Joseph Dumol
Merged: |
-------------------------+--------------------------------------------------
Comment(by was):
REFEREE REPORT:
The Sphinx docstrings that you added, which are very good, have a
formatting problem, namely below there needs to be a newline before each -
(i.e., lots of whitespace):
{{{
1315 INPUT:
1316 - ``username`` - a string
1317 - ``worksheet`` - an instance of Worksheet
1318
1319 OUTPUT:
1320 - a string containing the HTML
}}}
See this screenshot: http://wstein.org/home/wstein/tmp/jinja1.png which
illustrates how the ReST is messed up. This isn't a big deal, since I
don't think this code is even in the reference manual yet... But it would
be good to go through and fix.
All doctests pass, and *using* the notebook after applying the patches
seems to work fine -- I can't find any visible difference.
I give this a positive review. Proper Sphinxing of docs can go in a
future patch, and be done throughout the notebook server code.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6568#comment:30>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
