#11814: Catch and fix the segmentation fault in dlx_solver
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
jdemeyer | Status: needs_review
Type: | Milestone: sage-6.8
defect | Resolution:
Priority: | Merged in:
critical | Reviewers: Jeroen Demeyer
Component: | Work issues:
combinatorics | Commit:
Keywords: | 3a3dd8be8ff50d04bc84dc60401ea9af11871af6
Authors: | Stopgaps:
Sébastien Labbé |
Report Upstream: N/A |
Branch: |
u/slabbe/11814 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by slabbe):
* commit: 392b62c70d342679c41799e0b45857c537ad8a8e =>
3a3dd8be8ff50d04bc84dc60401ea9af11871af6
* branch: u/jdemeyer/11814 => u/slabbe/11814
Comment:
Great! I was feeling those `Py_INCREF` were not necessary and old fashion.
You were the good guy to clean/update that part. I removed the `cimport
Integer` which was unused.
There is one doctest failing in `combinat/tiling.py` because of the
`__str__ -> __repr__` change. I did not fix the doctest because I wonder
if showing a list of list is really what we want for the `__repr__`? Maybe
a repr saying `Dancing links of 34 rows` would be better together with a
method `rows` returning the rows?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=3a3dd8be8ff50d04bc84dc60401ea9af11871af6
3a3dd8b]||{{{Removed cimport Integer from dancing links}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/11814#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
