#18934: New (v,6,1)-BIBD with v<=201
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.8
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:  Dima Pasechnik
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/ncohen/18934     |  6ed1abf670cc7212d0f287458bd3af9588adf21c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dimpase):

 * status:  needs_review => positive_review
 * commit:  819bfa02346262814a0ff5ef3a9831eda7579739 =>
     6ed1abf670cc7212d0f287458bd3af9588adf21c
 * branch:  public/18934 => u/ncohen/18934


Comment:

 Replying to [comment:29 ncohen]:
 > > Well, you seem to prefer to hide the know-how how to use LJCR in this
 case.
 >
 > The interface with LJCR  has nothing to do with this function. There is
 no certitude that their entry will not change, there is no reason to carve
 in doctests that ours and theirs should match. This doctest tests more
 than the function claims, so it has no reason to be.
 >
 > > It's not fair to a user that might need to use it for a similar task.
 >
 > Nobody will have to. With this addition, there is no BIBD to be found on
 LJCR that Sage cannot build alone:
 >
 > {{{
 > sage: missing = [(v,k) for v in range(101) for k in range(1,v) if
 designs.balanced_incomplete_block_design(v,k,existence=True) is Unknown]
 > sage: for v,k in missing:
 > ....:     try:
 > ....:
 designs.balanced_incomplete_block_design(v,k,use_LJCR=True)
 > ....:         print "found"
 > ....:     except:
 > ....:         pass
 > ....:
 > sage:
 > }}}
 >
 > Do you intend to remove/fix the commit that contains the 'None == None'
 tests?

 never mind. You get your branch back :)

--
Ticket URL: <http://trac.sagemath.org/ticket/18934#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to