#10951: ecmfactor should take as optional argument the sigma value
-------------------------------------+-------------------------------------
       Reporter:  zimmerma           |        Owner:  tbd
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.4
      Component:  factorization      |   Resolution:
       Keywords:  sd32, sd40.5       |    Merged in:
        Authors:  Paul Zimmerman     |    Reviewers:  Mike Hansen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/10951                |  4a59cea09beb2c169e73bc3cc55da73843cde4d1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by chapoton):

 * commit:  27c99e1113d17c13c9aa7b9e4917ce7ba7e5404e =>
     4a59cea09beb2c169e73bc3cc55da73843cde4d1
 * branch:  u/zimmerma/10951 => public/ticket/10951


Comment:

 this looks good to me.

 I have removed some of the newly introduced random keywords.

 If somebody else agrees, this can be put into positive review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=173f5b0a700842fbe28124d112e210983031f746
 173f5b0]||{{{patch for #10951 (added optional input of sigma, and return
 lucky sigma)}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=45a5de7b282c93203733c3607f8f349d08a50448
 45a5de7]||{{{fixes and improved documentation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4a59cea09beb2c169e73bc3cc55da73843cde4d1
 4a59cea]||{{{trac #10951 not so many random}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/10951#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to