#17229: Replace generator_cmp by generator_key and generator_reverse
-------------------------------------+-------------------------------------
       Reporter:  aapitzsch          |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.9
      Component:  misc               |   Resolution:
       Keywords:  python3            |    Merged in:
        Authors:  André Apitzsch     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/aapitzsch/ticket/17229           |  f7edf1e577516a9ed7eeae69f24b3402a1803212
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * status:  needs_review => needs_work
 * milestone:  sage-6.4 => sage-6.9


Comment:

 Hello,

 1. Could you motivate a bit more this change. I do not find simpler to use
 a `key` function instead of a `cmp` function.

 2. It does not apply on the most recent version of Sage.

 3. I found the docstring confusing
 {{{
 def indices_key(self):
     r""""
     A comparison function on sets which gives a linear extension
     of the inclusion order
 }}}
    This is '''not''' a comparison function (which would have pairs as
 input)!

 More to come, when you answer 1

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/17229#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to