#18720: Change diagram algebra basis set partitions from list to generator
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.9
Component: algebra | Resolution:
Keywords: days65, partition | Merged in:
algebra, diagram algebra | Reviewers: Travis Scrimshaw
Authors: George H. | Work issues:
Seelinger | Commit:
Report Upstream: N/A | d424bcf88796291b1a3d68a7545774b67ac00b70
Branch: | Stopgaps:
u/tscrim/diagram_algebra_improvements-18720|
Dependencies: #18707 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: b6470c267b377868c654c406268113ead1995c02 =>
d424bcf88796291b1a3d68a7545774b67ac00b70
* branch: u/ghseeli/diagram_algebra_improvements-18720 =>
u/tscrim/diagram_algebra_improvements-18720
Comment:
Finally had time to finish my review changes...sorry it took so long. I
changed the interface for getting compact representations to use a global
option you can set via the Brauer algebra or diagrams (the parent). There
might be some more documentation fixes that need to be done, but overall
I'd be happy with this going into Sage as is. Please check my changes, and
if you're happy with them, then you can set a positive review.
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=db0ab963dd1ce10ebb9f4fedc269a433ddf60e88
db0ab96]||{{{Changed all 'returns' in the documentation to 'return'}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e70207a13dadbbaff347fd487fcbc3105e38d9d0
e70207a]||{{{added more doctests to methods that did not have them}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b875af7ac98e1184e31cbcbc5152efeeceefabe1
b875af7]||{{{Added more doctests for cardinality and element_constructor
methods}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8c437c572e7fcdb978f1cdf760b19a1a848fa4fe
8c437c5]||{{{added a few more doctests for a few methods I missed}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6da0724e5cc4201df635a1afa40635e389083f64
6da0724]||{{{Added necessary doctests to many more __ methods}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3d59b52b8743c10b5ebd39de2a4692a72d8e7581
3d59b52]||{{{fixed a few typos}}}||
||[http://git.sagemath.org/sage.git/commit/?id=e66621fcc50175b120a3a006288347403ba1b615
e66621f]||{{{Added attribution to authors in source}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4aab0caaa22c7c06d125719451be93d458e85dfb
4aab0ca]||{{{changed major typo in AbstractDiagrams initializer}}}||
||[http://git.sagemath.org/sage.git/commit/?id=01c0c041b5739189f234fafaa707ab935ad97b9d
01c0c04]||{{{Doing some cleanup and adding a global options.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d424bcf88796291b1a3d68a7545774b67ac00b70
d424bcf]||{{{Merge branch 'u/ghseeli/diagram_algebra_improvements-18720'
of trac.sagemath.org:sage into
u/tscrim/diagram_algebra_improvements-18720}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18720#comment:45>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
