#18613: Errors with is_isomorphic() for trivial cones
-------------------------------------+-------------------------------------
Reporter: mjo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: geometry | Resolution:
Keywords: cone | Merged in:
Authors: Andrey | Reviewers: Michael Orlitzky
Novoseltsev | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9c5f3f990ab80f980df85cb16f4b7d87f31a2fb9
u/mjo/ticket/18613 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by mjo):
* reviewer: => Michael Orlitzky
* branch: u/novoselt/errors_with_is_isomorphic___for_trivial_cones =>
u/mjo/ticket/18613
* commit: 40b87be348e7f976614becf8c0cdbbb8fc546fa8 =>
9c5f3f990ab80f980df85cb16f4b7d87f31a2fb9
Comment:
The first few fixes look good, but I have no idea what's going on with the
HNF stuff and I'm not sure we can just throw it out. Would you be willing
to move that to another ticket where someone more qualified can look at
it?
I've attempted to fix the `is_immutable()` issue separately (basically
dropped your last two commits and made a copy of the trivial matrix in
`echelon_form`). The only other issues were leading whitespace and that
new OUTPUT block that I tried to clarify a little. It passes a ptestlong
but leaves the pivot stuff as Somebody Else's Problem.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=b5a514dc5d053ac7b62b95a5a13db42217d47df0
b5a514d]||{{{Trac #18613: Remove leading whitespace, and reword an OUTPUT
block (reviewer).}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9c5f3f990ab80f980df85cb16f4b7d87f31a2fb9
9c5f3f9]||{{{Trac #18613: Make trivial echelon_form()s immutable
(reviewer).}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18613#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
