#19022: a few badly formatted REFERENCE block
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  chapoton               |       Status:  needs_review
           Type:         |    Milestone:  sage-6.9
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Nathann Cohen
  documentation          |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  4330d31073ad595b334aded188a9366fdf1671eb
  Frédéric Chapoton      |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/chapoton/19022       |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by ncohen):

 * reviewer:   => Nathann Cohen


Comment:

 Some remarks:

 {{{
 -        L is a list of cards of length 6, taken from {0,1,...,11}.
 +        """L is a list of cards of length 6, taken from {0,1,...,11}.
 }}}

 The usual style in Sage is to start the docstring at the line that follows
 {{{"""}}}


 {{{
 -        MINIMOG = self.minimog
 +        # MINIMOG = self.minimog
 }}}

 Why the comment? If it is useless, why don't you remove the line?

 Finally, the reference toward {{{error-correcting codes from game
 theory}}} (and the next one) are not formatted as they should.

 You can fix those as you see fit, and set this ticket to `positive_review`
 afterwards on my behalf.

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19022#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to