#19017: improving the big_oh interface + passing keywords
-------------------------------------+-------------------------------------
       Reporter:  behackl            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  commutative        |   Resolution:
  algebra                            |    Merged in:
       Keywords:  gsoc15             |    Reviewers:  Daniel Krenn
        Authors:  Benjamin Hackl,    |  Work issues:
  Daniel Krenn                       |       Commit:
Report Upstream:  N/A                |  d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
         Branch:                     |     Stopgaps:
  u/dkrenn/asy/big_oh                |
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Benjamin Hackl, Daniel Krenn', 'oldvalue': 
u'Benjamin Hackl'}):

 * commit:  3145afd634e3b8512090e2052af50a8cda16488c =>
     d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
 * reviewer:   => Daniel Krenn
 * author:  Benjamin Hackl => Benjamin Hackl, Daniel Krenn


Comment:

 Patch looks fine.

 I've added a small reviewer patch, which improves the error messages.
 Please do a cross-review and if satisfied set it to positive_review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=d7b7d9ef50a46c49d2b3b3e45589685f4b6ec4ee
 d7b7d9e]||{{{improve error message}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19017#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to