#19018: More SRGs using Regular Symmetric Hadamard matric with Constant Diagonal
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Dima Pasechnik
theory | Work issues:
Keywords: | Commit:
Authors: | 80846e1bd3695f0fd512c6257ac8961456939243
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/19018 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* status: positive_review => needs_work
Comment:
> you have a number of such cdef'd functions in this file, e.g.
`eigenvalues`. It is clear it can be doctested too...
This function is a cdef function because it needs to be fast. So it can't.
> In `H_3_cayley_graph()` case, it's clear it's basically a macro used in
two different places, for this fine language forgot to have macros
implemented... Would you like me to convert it into a decorator?!
I want you to do the job properly: either you copy paste it, or you
document what you write. You don't turn a function into a 'cdef' function
just because you don't want to write documentation.
Besides, you don't give a positive review to your own changes. Period.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19018#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
