#18696: Add lineality() method for convex cones
-------------------------------------+-------------------------------------
Reporter: mjo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Michael Orlitzky | Reviewers: Andrey Novoseltsev
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mjo/ticket/18696 | ed422e3d3eaed45d146398ffffc640ab4fe1abe7
Dependencies: #18454 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by novoselt):
* reviewer: => Andrey Novoseltsev
Comment:
As it is a small addition, tiny nitpicks:
- let's change "Compute" to "Return" - to me "compute ..." means that
computation is performed and perhaps stored in a cache without returning
anything, such methods are certainly useful especially as helpers
- you can use combined inequalities in Python:
{{{
sage: 0 <= l <= K.lattice_dim()
}}}
rather than
{{{
sage: (0 <= l) and (l <= K.lattice_dim())
}}}
- PEP8 suggests only one blank line between methods and two between
classes https://www.python.org/dev/peps/pep-0008/#blank-lines
- not sure I ever read a style guide for it, but it seems strange to me
to have an empty line in the very end of a docstring ;-)
--
Ticket URL: <http://trac.sagemath.org/ticket/18696#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
