#19049: New Hyperbolicity Algorithm
-------------------------------------+-------------------------------------
Reporter: borassi | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: Hyperbolicity | Merged in:
Authors: Michele Borassi | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/borassi/new_hyperbolicity_algorithm|
e2fe1c11dee8d5424927eb2a002c92687536b68e
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dcoudert):
It's working very well. I have very few and minor comments
- reduce the number of iterations of the test `for i in range(100): # long
time`. 10 is enough.
- replace reference [CCL12] with [CCL15]: N. Cohen, D. Coudert, A. Lancin.
On computing the Gromov hyperbolicity. ACM Journal of Experimental
Algorithmics, 20(1.6):1-18, 2015. [`<http://dx.doi.org/10.1145/2780652>`_]
or [`<https://hal.inria.fr/hal-01182890>`_]
- I think it is better to write `for b in range(D-1,-1,-1):` than `for b
from D > b >= 0:` although the later is easier to read. see
http://docs.cython.org/src/userguide/language_basics.html#integer-for-
loops
- Instead of `c = a`, `a = b` and `b = c` you can write directly `a,b =
b,a`
- When you `# We reset acc_bool`, it might be easier to use `memset`. This
part has negligeable impact on the computation time anyway.
David.
--
Ticket URL: <http://trac.sagemath.org/ticket/19049#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
