#19065: A few fixes and enhancements for chain complex morphisms
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers: Travis Scrimshaw
Authors: John Palmieri | Work issues:
Report Upstream: N/A | Commit:
Branch: | 45e2206b323ad222e818be931a9e77a4a213b14c
u/jhpalmieri/chains | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
It looks like you also fixed a bug if there was a mismatch in the matrix
dictionaries (which would result it a `KeyError` being thrown). Do you
think you could also add a test for this? If this could never happen, then
I'd revert back to directly calling `x._matrix_dictionary[i]`
Could you also make this doc tweak:
{{{#!diff
"""
- The matrix representing this morphism in degree n
+ The matrix representing this morphism in degree `n`.
INPUT:
- - ``n`` - degree
+ - ``n`` -- degree
}}}
If you make those changes and the patchbot approves, then you can set this
as a positive review on my behalf. Thanks.
--
Ticket URL: <http://trac.sagemath.org/ticket/19065#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
