#19048: AsymptoticRing: an_element
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.9
      Component:  symbolics          |   Resolution:
       Keywords:  asymptotics        |    Merged in:
        Authors:  Daniel Krenn       |    Reviewers:  Benjamin Hackl
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dkrenn/asy/an_element            |  3a44a01c5f3d39c51071d57f7ae5648ba63dbba8
   Dependencies:  #17716, #19047     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * commit:  9c1fc0e5ae62f1fdfc59acea333ea9df9637e0b7 =>
     3a44a01c5f3d39c51071d57f7ae5648ba63dbba8


Comment:

 Replying to [comment:4 behackl]:
 > I've reviewed your changes, merged the latest `asy/asymptoticExpression`
 into this branch and applied a tiny reviewer's patch (somehow, `'exact`
 was pasted where it definitely should not). In principal, everything looks
 good to me and the doctests pass.

 Thanks.

 > However, do you think that `asymptotic_term.py` really is the best place
 for the `product_diagonal` function? I do understand that it is required
 as a helper function there -- but nevertheless, from my point of view, the
 function is sufficiently general so that it could also live, for example,
 in `src/sage/misc/misc.py`.

 I would keep it here, as it is needed (at the moment) only here.
 ----
 Last 10 new commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=6d018150841c4a9d5ab26c96b8ecf1da40117686
 6d01815]||{{{Merge branch 'asy/asymptoticTerm' into
 asy/asymptoticExpression}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f6c4d80aa67e622a0b3ef576b2abe29565cbf88e
 f6c4d80]||{{{doctests fixed}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c7afc80e1ff9218390aa501b8f1a94a517e0bab9
 c7afc80]||{{{building documentation fixed}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=9305ca5fa737bcea5c728b7156514893b9d33ab1
 9305ca5]||{{{add . after seealso-lists}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=50d7166c926186e6aedff82e60aefe016896fe52
 50d7166]||{{{\mathbb{Q} --> \QQ}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=2f8146d6905357506ae2b883b18121fd1b65f995
 2f8146d]||{{{doctests: add growth_group= and coefficient_ring= to
 AsymptoticRing(...) generation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=64563002a4d2579b7eb280c1807d108af51e3ea3
 6456300]||{{{minor rewording in docstring}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4e7b080f1e7da508c319d7b0c7a7ea40ccd97521
 4e7b080]||{{{Merge branch 'u/dkrenn/asy/asymptoticExpression' into
 asy/asymptoticExpression and fixed some merge conflicts}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=ae47bcb707433c506d259599c06dd2325ab93ab8
 ae47bcb]||{{{Merge remote-tracking branch
 'origin/u/behackl/asy/asymptoticExpression' into
 t/19048/asy/an_element}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3a44a01c5f3d39c51071d57f7ae5648ba63dbba8
 3a44a01]||{{{fix imports to make doctests pass}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19048#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to