#6388: [with patch, needs review] Logarithm function log(x) is partially broken
for x <= 0
-----------------------+----------------------------------------------------
 Reporter:  gmhossain  |       Owner:                        
     Type:  defect     |      Status:  new                   
 Priority:  major      |   Milestone:                        
Component:  symbolics  |    Keywords:  negative argument, log
 Reviewer:             |      Author:  Karl-Dieter Crisman   
   Merged:             |  
-----------------------+----------------------------------------------------

Comment(by gmhossain):

 Hi,

 Thanks, you have added more features than I had wanted. Here are my last
 comments before
 I give positive review:

 {{{
 sage: log(SR(-1), e)
 I*pi
 sage: log(CDF(-1), e)
 3.14159265359*I
 }}}

 works but it doesn't work or CC, RR, CIF...

 I think, it would be better if you could change this two lines in log()
 {{{
 except AttributeError:
     return ln(x) / ln(base)
 }}}

 to

 {{{
 except (AttributeError, TypeError):
     return log(x) / log(base)
 }}}

 We should call log() recursively so that it can take advantage of
 the features that you have added. Another supplementary patch should be
 fine too.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6388#comment:5>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to