#18656: Cache rational_diagonal_form()
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: quadratic forms | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/cache_rational_diagonal_form__|
e995d5e42c65a332a1d1eb6eb86717f3978f821a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_work => needs_review
Comment:
Replying to [comment:3 vdelecroix]:
> Since `T` is computed each time, why not returning it by default? If you
use a `cached_method` you should minimize the number of arguments.
>
> Also, make the output matrices immutable.
Done, I made `rational_diagonal_form()` a front-end for a cached function
`_rational_diagonal_form_and_transformation()` which returns the form and
matrix.
--
Ticket URL: <http://trac.sagemath.org/ticket/18656#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
