#18946: unweighted matroid intersection using blocking flow approach
-------------------------------------+-------------------------------------
       Reporter:  chaoxu             |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.9
      Component:  matroid theory     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Chao Xu            |    Reviewers:  Stefan van Zwam
Report Upstream:  N/A                |  Work issues:
         Branch:  u/chaoxu/faster-   |       Commit:
  abstract-matroid-intersection      |  195feb847638db2c2b1763a1283c9ef31a81fa25
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Chao Xu', 'oldvalue': ''}):

 * status:  needs_review => positive_review
 * reviewer:   => Stefan van Zwam
 * author:   => Chao Xu


Comment:

 I did a bunch of tests, and the output was always correct. Also, timing
 tests now show a consistent speedup. It's good to go in as far as I'm
 concerned!

 {{{
 sage: def test():
     for i in xrange(1000):
             M1 = Matroid(MatrixSpace(GF(7), 50, 2000).random_element())
             M2 = Matroid(MatrixSpace(GF(3), 50, 2000).random_element())
             X = M1.intersection(M2)
 ....:
 sage: %time test()
 CPU times: user 21min 49s, sys: 25.8 s, total: 22min 15s
 Wall time: 22min 17s
 sage: def test2():
     for i in xrange(1000):
             M1 = Matroid(MatrixSpace(GF(7), 50, 2000).random_element())
             M2 = Matroid(MatrixSpace(GF(3), 50, 2000).random_element())
             X = M1._intersection_unweighted(M2)
 ....:
 sage: %time test2()
 CPU times: user 11min 43s, sys: 936 ms, total: 11min 44s
 Wall time: 11min 44s
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/18946#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to