#15875: Add is_subposet
-------------------------------------+-------------------------------------
       Reporter:  csar               |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.9
      Component:  combinatorics      |   Resolution:
       Keywords:  posets             |    Merged in:
        Authors:  Jori Mäntysalo     |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jmantysalo/is_subposet           |  29ab8f2b3ba3fb8d6366f694c26866e1c0f3e4fe
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_review => needs_work


Comment:

 However it is a subposet, but yes, up to isomorphism (which, IMO, is what
 most mathematicians care about; I think of `2+2` and `1+3` freeness).
 However my impression of the docstring was the difference between the
 methods was if the diamond is considered as a subposet inside
 {{{
      1
     / \
    2   3
   /     \
  4       5
   \     /
    6   7
     \ /
      8
 }}}
 I don't like the fact that `is_subposet`, which is likely to be the first
 encountered method for this type of behavior, is caring about the element
 labels. Even more so that there is not any part of the documentation which
 suggests that it looks at labels. So you need to rework the documentation.

--
Ticket URL: <http://trac.sagemath.org/ticket/15875#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to