#18987: Parallel computation of number of solutions in dancing links
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  slabbe                 |       Status:  needs_review
           Type:         |    Milestone:  sage-6.9
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Vincent Delecroix
  combinatorics          |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  29ff98625316f95c48fd704115a209dce38deda8
  Sébastien Labbé        |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/18987           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by slabbe):

 * status:  needs_work => needs_review


Comment:

 Thanks for your review! I fixed the first comments.

 > - I do not see the point of having `number_of_solutions_iterator` and
 `number_of_solutions`. You should just get rid of the first one and allow
 parallelization in the second.

  - `number_of_solutions_iterator` is now `_number_of_solutions_iterator`
  - `number_of_solutions` now allows parallel computation
  - I kept `_number_of_solutions_iterator` because for the problem I am
 currently looking at, `number_of_solutions` takes days while
 `_number_of_solutions_iterator`  yield something once every hours. So it
 allows me to follow the computation, making sure it is not stuck and
 evaluate the duration left to do. I prefer this way rather than removing
 method `_number_of_solutions_iterator` and adding some verbose thing in
 `number_of_solutions`.

 > - Why not also make available parallelization for getting the list of
 solutions?

 Because I don't know how or if it is possible to use the parallel
 decorator to merge iterators.

--
Ticket URL: <http://trac.sagemath.org/ticket/18987#comment:67>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to