#19161: LatticePoset: faster is_complemented()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen, | Reviewers:
Jori Mäntysalo | Work issues:
Report Upstream: N/A | Commit:
Branch: | b8853ed85f14cb8b3d2a9046d31505bf81223c7d
u/jmantysalo/faster_is_complemented| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by nadialafreniere):
* cc: nadialafreniere (added)
* status: needs_review => needs_work
Comment:
Hi Jori,
I'm Mélodie's colleague and I reviewed the graph documentation ticket with
her.
About your new ticket, now.
{{{#!diff
+ n = self.cardinality()-1
+ for row1,row2 in izip(mt, jn):
+ for c1,c2 in izip(row1,row2):
+ if c1==0 and c2==n:
}}}
You should respect the Python / Sage conventions and add spaces before and
after binary operators of the lowest priority : `self.cardinality() - 1`,
`c1 == 0`, etc. This includes equality and assignments.
As well, there should be spaces after every coma sign: `row1, row2`, `c1,
c2`, `izip(row1, row2)`. For more info on these conventions, see
http://doc.sagemath.org/html/en/developer/coding_basics.html#python-code-
style
--
Ticket URL: <http://trac.sagemath.org/ticket/19161#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
