#19150: Moving lyndon_word.py in sage.combinat.words
-------------------------------------+-------------------------------------
Reporter: nadialafreniere | Owner:
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: Lyndon words, | Merged in:
days69 | Reviewers:
Authors: Nadia Lafrenière | Work issues:
Report Upstream: N/A | Commit:
Branch: | efb48730e10a85726211954093f594db275935c8
u/nadialafreniere/moved_lyndon | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
1. You cannot just put docstrings in arbitrary places. So in
`src/sage/combinat/lyndon_word.py`, you should replace
{{{
"""
docstring
"""
code
"""
doctests
"""
}}}
by
{{{
"""
docstring
doctests
"""
code
}}}
2. The indentation of the docstring is wrong:
{{{
TESTS::
sage: ...
}}}
should become
{{{
TESTS::
sage: ...
}}}
3. Instead of testing `import *`, I would prefer to see a more concrete
import (say `LyndonWord`)
--
Ticket URL: <http://trac.sagemath.org/ticket/19150#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
