#4786: [with patch, needs review] fix some bugs / typos in the solve function
---------------------------+------------------------------------------------
Reporter: was | Owner: burcin
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: calculus | Keywords:
Reviewer: Burcin Erocal | Author: Karl-Dieter Crisman
Merged: |
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Burcin Erocal
* author: => Karl-Dieter Crisman
Comment:
Hi Karl-Dieter,
I uploaded a new version of your patch at
attachment:trac_4786-solution_dict.take2.patch. The changes are:
* used `sorted( d.items() )` to print a dictionary in a doctest
* changed the block:
{{{
try:
sol_dict=[dict([[eq.left(),eq.right()] for eq in
solution]) for solution in sol_list]
except TypeError:
if not isinstance(sol_list[0],list):
sol_list = [[i] for i in sol_list]
sol_dict=[dict([[eq.left(),eq.right()] for eq in
solution]) for solution in sol_list]
}}}
to
{{{
if isinstance(sol_list[0], list):
sol_dict=[dict([[eq.left(),eq.right()] for eq in
solution])
for solution in sol_list]
else:
sol_dict=[{eq.left():eq.right()} for eq in sol_list]
}}}
Please give this ticket a positive review if you're ok with my changes.
----
Minh, only apply: attachment:trac_4786-solution_dict.take2.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4786#comment:4>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
