#16204: Add some methods in trees
-------------------------------------+-------------------------------------
Reporter: boussica | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Adrien | Reviewers: Vincent Delecroix
Boussicault | Work issues:
Report Upstream: N/A | Commit:
Branch: | 6bde7929af3de9ef187c336108a21aec9666aad7
u/boussica/add_methods_in_trees | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* reviewer: => Vincent Delecroix
Comment:
Hi,
1. Please remove trailing whitespaces.
2. Is it pep8 to have paranthesis after opening paranthesis and before
closing ones? (like `( a )`)
3. In
{{{
Return the number of left nodes number is ``direction``
}}}
the `is` should be `if`.
4. Using recursive function is a bad idea. Python is not designed to
support smartly recursive function calls. You would better use depth first
search.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16204#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
