#19113: LatticePoset: Return type category of product()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: poset, | Merged in:
latticeposet | Reviewers:
Authors: Jori Mäntysalo | Work issues:
Report Upstream: N/A | Commit:
Branch: | 3346ee8d02a1db3e13860a370caf40ca55bf441d
u/jmantysalo/latticeposet__return_type_category_of_product__| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:7 tscrim]:
> - You've not added any tests which check that this is fixed.
> - Cartesian should be capitalized.
OK, I'll do these.
> - Why did you make all of the changes to the table of methods?
Because it is more logical to have for example `comparability_graph()` and
`comparability_graph()` together and `promotion()` and `evacuation()` as a
pair. All changes are for "uncategorized" functions at the index.
> Also I'm not going to set a positive review on tickets that change
{{{``self``}}} to `this poset` (that's not to say I'm not going to allow a
positive review, but it's my somewhat mild form of protest).
Duh. Can you make a patch to convert all `the poset` and `this poset` to
{{{``self``}}}? Maybe a year ago I was pointed to style guide that adviced
against `self`. But almost everything is OK for me, as long as it is
uniform accross the software.
--
Ticket URL: <http://trac.sagemath.org/ticket/19113#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
