#19223: Graphs: missing error check for depth_first_search(..., distance=0)
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: new
Priority: minor | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/graphs__missing_error_check_for_depth_first_search______distance_0_|
ec0e5b3167db96d936ed1f70bb8dbbcb19201895
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello Jori,
What you did is not exactly wrong, but we should really find something
better than adding 30 lines of code to deal with a rather stupid corner-
case. Though I admit that I do not see one at the moment.
Technically (though that is not the biggest problem here) try to only wrap
the smallest amount of line in a try/except. When you write too much in a
try/except, you run the risk of catching exceptions raised legitimately by
other functions.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19223#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
