#18376: New encoding structure for linear codes
-------------------------+-------------------------------------------------
Reporter: | Owner:
dlucas | Status: needs_review
Type: | Milestone: sage-6.9
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
coding theory | Work issues:
Keywords: | Commit:
Authors: David | 2115bf45aadf6dcf104031cdcbd86a0787fb9def
Lucas | Stopgaps:
Report Upstream: N/A |
Branch: |
u/dlucas/encoder |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by dlucas):
I made (almost all) the requested changes.
A few remarks:
On comment 4, note that I kept the sentence starting by "returns ..." to
stick to [http://doc.sagemath.org/html/en/developer/coding_basics.html
#the-docstring-of-a-function-content docstring formatting rules].
On comment 6, I don't really get what you suggest. Do you propose to
somehow register the unencoder_matrix and the information_set, for
instance as some kind of class argument after their first computation?
On comment 9, I can't see what kind of other error can occur when encoding
a word. Either it's an element from the message space and encoding goes
well, either it's not and you get an error as illustrated in the doctest
of `encoder`. Or am I missing something here?
On comment 12, I actually deleted the whole block.
On comment 19, I changed the `.. NOTE` block to a `.. WARNING` block to
make this remark even more visible on the doc of `AbstractLinearCode`.
On comment 23, it's more helpful indeed. Change done.
On comment 24, as `c` is not necessarily a codeword (if `nocheck = True`,
you can provide anything you want, as long as it belongs to the ambient
space), I did not change the `INPUT` line for `c`.
On comment 26, it's already the case. Maybe you meant "shouldn't include
the word "the" ", but in that case I think the error message would seem a
bit weird imho. I have no strong feelings on this though.
Best,
David
--
Ticket URL: <http://trac.sagemath.org/ticket/18376#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
