#19197: LatticePoset: add breadth()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet__add_breadth__|
b3ae7c4d82d67adb484d53fdecec4256b196e6a1
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Helloooooooooooo,
I've got only one thing to add to this code: `self[e]` looks dangerous to
me, just because I do not know what exactly it does. The `__getitem__`
function defined on posets seems to be inherited and (very) generic. In
particular, I suspect that `self[e]` may be as "efficient" as
`list(self)[e]`. I think that you should prefer `_element_to_vertex(x)` in
this situation.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19197#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
