#18762: Create coercion between diagram algebras and the symmetric group algebra
-------------------------------------+-------------------------------------
Reporter: ghseeli | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: algebra | Resolution:
Keywords: diagram algebra, | Merged in:
partition algebra, days65 | Reviewers:
Authors: George H. | Work issues:
Seelinger | Commit:
Report Upstream: N/A | 2adcfeffa5d87f137ee9010fb69087a2b76e98a7
Branch: | Stopgaps:
u/ghseeli/create_coercion_between_diagram_algebras_and_the_symmetric_group_algebra|
Dependencies: #18720 |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
Comment:
Hello,
Just some sided remarks.
- You have more commits than the number of lines you modified! Moreover
most of your commit messages are completely useless. The git history is
important since it is used to find out which commit is responsible for a
given change. You would better start a new (clean) branch from scratch.
- methods must be documented (see
[http://doc.sagemath.org/html/en/developer/coding_basics.html
#documentation-strings the developer guide])
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/18762#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
