#19240: Rename matrix_mod2e_dense to matrix_gf2e_dense
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  trivial            |    Milestone:  sage-6.9
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:  Simon King
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/SimonKing/rename_matrix_mod2e_dense_to_matrix_gf2e_dense|  
1e47929f96da76765a17545e356a96d2f153e26a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):

 * status:  needs_review => positive_review


Comment:

 Since tests pass and the code and docstrings now seem fine, I'm giving it
 a positive review.

 Unless of course you don't like my reviewer commits, or unless you worry
 about the patchbot reporting a slowdown in startup time (which I find hard
 to believe, given that you merely rename a module).

--
Ticket URL: <http://trac.sagemath.org/ticket/19240#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to