#6681: [with spkg, needs work] cliquer doesn't work in 64-bit OS X
--------------------------+-------------------------------------------------
Reporter: jhpalmieri | Owner: rlm
Type: defect | Status: new
Priority: major | Milestone: sage-4.1.2
Component: graph theory | Keywords:
Reviewer: | Author: Minh Van Nguyen
Merged: |
--------------------------+-------------------------------------------------
Comment(by was):
Some comments:
* The spkg-install script has
{{{
mkdir "$SAGE_LOCAL/include/cliquer/"
cp src/*.h "$SAGE_LOCAL/include/cliquer/"
}}}
at the top. There are two problems with this:
1. If the build fails, you've just possibly messed up $SAGE_LOCAL. It's
best if when building nothing is changed in SAGE_LOCAL unless the build
succeeds. So just move these lines down past the make line.
2. After the first time cliquer is installed, any future time it is
installed the line {{{mkdir "$SAGE_LOCAL/include/cliquer/"}}} will give an
error (which is ignored since the error isn't checked):
{{{
bash-3.2$ mkdir "$SAGE_LOCAL/include/cliquer/"
mkdir: /Users/wstein/sage/build/64bit/sage/local/include/cliquer/: File
exists
}}}
* After the "make" command, no error checking is done. If the make fails
you might not even know!
{{{
cd src
make
cp -f libcliquer.so "$SAGE_LOCAL/lib/"
}}}
You just luck out if it happens that the make failing doesn't produce
libcliquer.so since that cp line just happens to be the last line of the
file. You need to check the output code of the make like is done in every
other spkg-install.
* Regarding the line that Kirkby pointed out that "CC=gcc". That's
trivial to fix -- just delete it in Makefile! Since CC gets sets before
spkg-install is run, it isn't something your spkg has to worry about.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6681#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
