#19247: Two SRG on 243 and 276 vertices
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  ncohen                 |       Status:  positive_review
           Type:         |    Milestone:  sage-6.9
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  f69cab0a4295f51c562993965821ba72bf1d409d
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  public/19247           |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by dimpase):

 * status:  needs_review => positive_review


Comment:

 Replying to [comment:5 ncohen]:
 > The typo is fixed, and you will notice that it had nothing to do with
 this branch. Next time you spot a typo in a function which is not related
 to ticket X, instead of having the author of X fix it for you it would be
 better manners to add a commit yourself if you care.

 well, I didn't have time for this then...
 >
 > About sum: by default in a .py file the 'sum' is Python's sum. The
 symbolic sum would have to be imported manually, which I did not do.

 same in .pyx ? OK; it seems I'd remove some such imports I did... OK, not
 here, certainly.

 Otherwise, looks good to me.

--
Ticket URL: <http://trac.sagemath.org/ticket/19247#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to