#17693: mutable poset: a data structure for asymptotic expressions
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.5
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics | Reviewers: Benjamin Hackl
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: u/behackl/asy | 3b3b2fb607a6fe8b20419170bf935d494af1efca
/mutable-poset | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by behackl):
* commit: 1d52f6c6351e6eb9e92c6033b12e09c4754b8110 =>
3b3b2fb607a6fe8b20419170bf935d494af1efca
* branch: u/dkrenn/asy/mutable-poset => u/behackl/asy/mutable-poset
Comment:
A short remark on this change of mind:
When deriving these classes from `SageObject` instead of `object`, and
merging this ticket into #17716 (our `AsymptoticRing`), doctests were
failing because we call `A(poset)` with an `AsymptoticRing` `A` there,
which causes some peculiarities in `_coerce_map_from_`.
In any case, we fixed these problems there, so this can be properly
derived from `SageObject`.
This concludes my review; [comment:8 cheuberg] is in the process of
reading the code. I'll leave setting this to `positive_review` to him.
Benjamin
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=fd7c881001b0dc480e596e61578aa87afa80e638
fd7c881]||{{{Applies --> Apply in one-line of docstring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=dabad1f4c953f9a4e0f973f2ee7c46cbb0d15752
dabad1f]||{{{remove reverse in is_{null|oo} since not needed}}}||
||[http://git.sagemath.org/sage.git/commit/?id=33c410238a9352d08b5634a60b6ed30b8f0d3aad
33c4102]||{{{mark doctests in .le as indirect}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b31fac80d649c8351e20d90dfdff39d28c91d21f
b31fac8]||{{{rewrite a couple of one-line descriptions}}}||
||[http://git.sagemath.org/sage.git/commit/?id=17e921ffeb31ed529f9686ed5c54d48e36b248cf
17e921f]||{{{remove sorted_set_by_tuple}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7af4b6bf109a4eeb1f09a386ecbf5cdeb51a0cbe
7af4b6b]||{{{remove reverse keyword from shells}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a49a20db5ec0d19d50621de6286ddc11e737735f
a49a20d]||{{{add comment in code to make it clear what happens}}}||
||[http://git.sagemath.org/sage.git/commit/?id=89b82093fecc685245c824ab9284a67c198be50f
89b8209]||{{{change left/right to self/other}}}||
||[http://git.sagemath.org/sage.git/commit/?id=1d52f6c6351e6eb9e92c6033b12e09c4754b8110
1d52f6c]||{{{add a note to the set operations methods}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3b3b2fb607a6fe8b20419170bf935d494af1efca
3b3b2fb]||{{{object --> SageObject}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17693#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.