#19270: Matrix_integer_sparse object has no attribute 'gap'
--------------------------------+------------------------
       Reporter:  slabbe        |        Owner:
           Type:  defect        |       Status:  new
       Priority:  major         |    Milestone:  sage-6.9
      Component:  group theory  |   Resolution:
       Keywords:                |    Merged in:
        Authors:                |    Reviewers:
Report Upstream:  N/A           |  Work issues:
         Branch:                |       Commit:
   Dependencies:                |     Stopgaps:
--------------------------------+------------------------

Comment (by tscrim):

 None of the matrices have a `gap` method.

 The code is assuming that the input are elements of `G`; so it is bad
 input. However, to make things more robust and better behaved, I would
 make this change (the cost of the coercion call should be minimal):
 {{{#!diff
 -generators = [ g if isinstance(g, GapElement) else g.gap()
 +generators = [ g if isinstance(g, GapElement) else self(g).gap()
                 for g in generators ]
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/19270#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to