#18223: cartesian products with orders
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.7
Component: categories | Resolution:
Keywords: sd67 | Merged in:
Authors: Daniel Krenn | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: u/dkrenn/cat | Commit:
/cartesian-product-posets | 4ac40147cd398c65cb524a8dfe59f7d5060788c6
Dependencies: #18586 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dkrenn):
* status: needs_info => needs_review
Comment:
Replying to [comment:36 vdelecroix]:
> Replying to [comment:35 dkrenn]:
> > > 12. What is the point of adding `*kwargs` in the `__init__` method
of `CartesianProduct`? If this argument is not supported then it should
simply not exists.
> >
> > This boils down to our discussion from #18586: They are passed on to
`CartesianProduct` where there is at least a `flatten` keyword. Thus there
is a keyword, so arguments are simply passed.
>
> I still do not understand at all. I am talking about
`sage.sets.cartesian_product.CartesianProduct`. Its constructor does not
pass its arguments to anybody. What is the subtle difference in behaviour
between `f` and `g` below?
> {{{
> def f(**kwds):
> if kwds:
> raise TypeError
> ...
>
> def g():
> ...
> }}}
> The only thing I see is that it needs much more to write `f`.
I think I see your point now and I have to admit I thought we were taking
about `CartesianProductPosets` (and not about `CartesianProduct`). I agree
that this is obsolete now. I've deleted it.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=4ac40147cd398c65cb524a8dfe59f7d5060788c6
4ac4014]||{{{remove kwargs in CartesianProduct since not needed}}}||
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=e87db1a0f635bb81e3510dfa7ca1617e31462380
e87db1a]||{{{rewrite (simplify) join of category}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6714aaaf749e2618e44fba307c0e0a389a4e73c1
6714aaa]||{{{add comment pointing to #19269 in doctests using QQ as
poset}}}||
||[http://git.sagemath.org/sage.git/commit/?id=298773edaa680205c4f7cccd1840f5ee28a63e3f
298773e]||{{{explain keyword order better}}}||
||[http://git.sagemath.org/sage.git/commit/?id=08469c7b76adfcd243fce084c1c8f2a94daa058e
08469c7]||{{{add module to reference/combinat docs}}}||
||[http://git.sagemath.org/sage.git/commit/?id=98c252fc4bf3e204c5f366115953c12c74bad701
98c252f]||{{{allow tuples as category}}}||
||[http://git.sagemath.org/sage.git/commit/?id=eb711e9cfb42ba6c993e1131da2298f45097e355
eb711e9]||{{{add TestSuite}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ca4a844746ef444eff10808002c022ac6c111cd0
ca4a844]||{{{minor rephrase of docstring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=693b0bd6b4e5bd6f49afc6db055b066856ae01e5
693b0bd]||{{{add a native order option}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f3b1387b378ce406e04c6f45c6629595a46640c8
f3b1387]||{{{use Posets.ChainPosets in a doctest}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4ac40147cd398c65cb524a8dfe59f7d5060788c6
4ac4014]||{{{remove kwargs in CartesianProduct since not needed}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/18223#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
