#17716: AsymptoticRing and AsymptoticExpression
-------------------------------------+-------------------------------------
Reporter: behackl | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.9
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: asymptotics, | Reviewers: Daniel Krenn, Clemens
gsoc15 | Heuberger
Authors: Benjamin Hackl, | Work issues:
Daniel Krenn | Commit:
Report Upstream: N/A | 4bb745f5d9f796c8485d23536cd456dde8a2201e
Branch: | Stopgaps:
u/cheuberg/asy/asymptoticExpression|
Dependencies: #17600, #17693, |
#17715, #18930, #19017 |
-------------------------------------+-------------------------------------
Changes (by cheuberg):
* status: needs_review => needs_work
* reviewer: Daniel Krenn => Daniel Krenn, Clemens Heuberger
* commit: 5f54aecc2a188ccf2711946c655c271386ae32c6 =>
4bb745f5d9f796c8485d23536cd456dde8a2201e
* milestone: sage-6.5 => sage-6.9
Comment:
I have read the code and the documentation. I have pushed a few reviewer
commits (please cross-review). Apart from that, I have a few
comments/questions:
1. Introductory examples, `A.an_element()`: why is this not tested?
2. `AsymptoticExpression.__init__`: all doctests are indirect; however
seeing `simplify` in action as well as a poset might be more interesting.
3. `AsymptoticExpression.__pow__`: How difficult would it be to allow the
computation of `(y^2)^(3/2)` ?
4. `AsymptoticExpression.__pow__`: move powers of asymptotic terms to the
respective classes instead of the hack here.
5. `AsymptoticRing`: "TEST": what is the purpose of this test? Isn't all
that already tested?
6. `AsymptoticRing.__classcall__`: the if clause `if names is not None`
does not seem to be prepared to multiple generators.
7. `AsymptoticRing.__classcall__`: deal with parameter `category`
8. `AsymptoticRing.__init__`: include doctests for error conditions.
9. `AsymptoticRing._element_constructor_`: clarify that `data=0` is
required if `summands is not None`
10. `AsymptoticRing._element_constructor_`: doctests for use of
`summands`, for error conditions
11. `AsymptoticRing._coerce_map_from_`: why is the test `if R ==
MutablePoset` required?
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=b92eb2aaad47de86a91bca52e0c554dd035811e8
b92eb2a]||{{{Trac #17716: minor language issues}}}||
||[http://git.sagemath.org/sage.git/commit/?id=61017c72e6e6c6d56a022616151bc867e67b5624
61017c7]||{{{Trac #17716: use next function instead of next method
(Python3 compatible)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0dc81e8cea8a6e7f3cb840069a9cde28d35498f2
0dc81e8]||{{{Trac #17716: language}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6f0d60f3bccf90ef0ae1b9b61d6b8b4dcb248bcf
6f0d60f]||{{{Trac #17716: simplified doctest}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8b29f921611e7cfd17a16d4170fc3108c3469131
8b29f92]||{{{Trac #17716: additional doctests}}}||
||[http://git.sagemath.org/sage.git/commit/?id=451b5e87f82b55f508c8bf95a0d7e62f5c0870ae
451b5e8]||{{{Trac #17716: PEP8 compliance}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7381430a7181eb0e755080a410c63810f242a3a2
7381430]||{{{Trac #17716: "not implemented" instead of "not tested"}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9bf196aa9827429847ac2a000d79924d8e365320
9bf196a]||{{{Trac #17716: fix errors}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a1881013338c835d4bfd808c01d780c94ab4a010
a188101]||{{{Trac #17716: fix TeX errors in docstrings}}}||
||[http://git.sagemath.org/sage.git/commit/?id=4bb745f5d9f796c8485d23536cd456dde8a2201e
4bb745f]||{{{Trac #17716: Heading "Classes and Methods"}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/17716#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
