#19291: Graph.spanning_trees does not like loops
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:
  Stefan                 |       Status:  positive_review
           Type:         |    Milestone:  sage-6.9
  defect                 |   Resolution:
       Priority:  major  |    Merged in:
      Component:  graph  |    Reviewers:  Stefan van Zwam
  theory                 |  Work issues:
       Keywords:         |       Commit:
        Authors:         |  6a86e239c68f0d66cc182a98e74f72b34df4f961
  Nathann Cohen          |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
  u/ncohen/19291         |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by Stefan):

 * status:  needs_review => positive_review
 * reviewer:   => Stefan van Zwam


Comment:

 I was just exploring some graph methods, I don't actually need to use it
 for now.

 Your change forces a copy of the graph to be made regardless of whether
 there are loops. That's definitely safer than what happened before, but
 could be costly in terms of memory for big graphs. Still, I prefer the
 corresponding increase in safety of the code, so I will approve.

--
Ticket URL: <http://trac.sagemath.org/ticket/19291#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to